Fix unsafe rawPointer access in cloneMultiple by bartlomiejbloniarz · Pull Request #55613 · facebook/react-native

bartlomiejbloniarz · 2026-02-18T11:24:20Z

Summary:
The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated.

Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself.

This cloneMultiple method isn't really adopted in the community, so the breaking change shouldn't be a big problem.

Changelog:
[General][Breaking] - fix unsafe rawPointer access in cloneMultiple.

Differential Revision: D93596770

meta-codesync · 2026-02-18T11:24:30Z

@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93596770.

Summary: The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770

github-actions · 2026-03-03T12:03:51Z

Job Summary for Gradle

Test All :: build_android

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
react-native-github	publishAllToMavenTempLocal build	9.3.1	❌

Summary: Pull Request resolved: #55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770

react-native-bot · 2026-03-03T12:05:43Z

This pull request was successfully merged by @coado in 8e5de46

^{When will my fix make it into a release? | How to file a pick request?}

github-actions · 2026-03-03T12:08:57Z

Job Summary for Gradle

Test All :: build_android

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
react-native-github	publishAllToMavenTempLocal build	9.3.1	❌

github-actions · 2026-03-03T12:12:33Z

Job Summary for Gradle

Test All :: run_fantom_tests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
react-native-github	:private:react-native-fantom:buildFantomTester	9.3.1	❌

github-actions · 2026-03-03T12:15:24Z

Job Summary for Gradle

Test All :: run_fantom_tests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
react-native-github	:private:react-native-fantom:buildFantomTester	9.3.1	❌

Summary: The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770

github-actions · 2026-03-03T12:30:13Z

Job Summary for Gradle

Test All :: build_android

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
react-native-github	publishAllToMavenTempLocal build	9.3.1	❌

Summary: Pull Request resolved: #55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770

react-native-bot · 2026-03-03T12:31:44Z

This pull request was successfully merged by @coado in f102dbe

^{When will my fix make it into a release? | How to file a pick request?}

github-actions · 2026-03-03T12:34:49Z

Job Summary for Gradle

Test All :: build_android

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
react-native-github	publishAllToMavenTempLocal build	9.3.1	❌

Summary: Pull Request resolved: #55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770

react-native-bot · 2026-03-03T12:35:58Z

This pull request was successfully merged by @coado in 6675f95

^{When will my fix make it into a release? | How to file a pick request?}

github-actions · 2026-03-03T12:38:58Z

Job Summary for Gradle

Test All :: build_android

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
react-native-github	publishAllToMavenTempLocal build	9.3.1	❌

github-actions · 2026-03-03T12:39:11Z

Job Summary for Gradle

Test All :: run_fantom_tests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
react-native-github	:private:react-native-fantom:buildFantomTester	9.3.1	❌

github-actions · 2026-03-03T12:44:29Z

Job Summary for Gradle

Test All :: run_fantom_tests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
react-native-github	:private:react-native-fantom:buildFantomTester	9.3.1	❌

github-actions · 2026-03-03T12:47:56Z

Job Summary for Gradle

Test All :: run_fantom_tests

Gradle Root Project	Requested Tasks	Gradle Version	Build Outcome	Build Scan®
react-native-github	:private:react-native-fantom:buildFantomTester	9.3.1	❌

Summary: The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770

Summary: Pull Request resolved: #55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770

react-native-bot · 2026-03-03T14:12:04Z

This pull request was successfully merged by @coado in 639c289

^{When will my fix make it into a release? | How to file a pick request?}

Summary: Pull Request resolved: #55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Reviewed By: zeyap, javache Differential Revision: D93596770

react-native-bot · 2026-03-03T14:19:46Z

This pull request was successfully merged by @coado in 41f59c4

^{When will my fix make it into a release? | How to file a pick request?}

react-native-bot · 2026-03-04T00:48:38Z

This pull request was successfully merged by @coado in 1d47693

^{When will my fix make it into a release? | How to file a pick request?}

Summary: Pull Request resolved: #55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Changelog: [General][Breaking] - fix unsafe rawPointer access in cloneMultiple. Reviewed By: zeyap, javache Differential Revision: D93596770 fbshipit-source-id: c4d99b51875968ebce50358c19502cba02c50685

Summary: Pull Request resolved: facebook#55613 The cloneMultiple method was written in a way to accept a list of families that are presumed to be owned by the api caller. This designe was mostly aimed at reanimated, that holds refernces to ShadowNodes (that own these families). In the case of AnimationBackend this didn't work properly, as when the view is unmounted we would lose the ShadowNodeFamily shared_ptr that we hold and it could get deallocated. Since now we can get an owning reference to ShadowNodeFamily from ShadowNode::getFamilyShared, we don't have to keep this old unsafe api. Instead we require the caller to have an owning reference with the api itself. This `cloneMultiple` method isn't really adopted in the community, so the breaking change shouldn't be a big problem. Changelog: [General][Breaking] - fix unsafe rawPointer access in cloneMultiple. Reviewed By: zeyap, javache Differential Revision: D93596770 fbshipit-source-id: c4d99b51875968ebce50358c19502cba02c50685

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2026

facebook-github-bot added p: Software Mansion Partner: Software Mansion Partner labels Feb 18, 2026

meta-codesync bot added fb-exported meta-exported labels Feb 18, 2026

facebook-github-bot added the p: Facebook Partner: Facebook label Feb 18, 2026

meta-codesync bot force-pushed the export-D93596770 branch from 5ecac9d to 37d37ce Compare March 3, 2026 12:00

bartlomiejbloniarz force-pushed the export-D93596770 branch from 37d37ce to 8e5de46 Compare March 3, 2026 12:05

react-native-bot added the Merged This PR has been merged. label Mar 3, 2026

meta-codesync bot force-pushed the export-D93596770 branch from 8e5de46 to dfffda3 Compare March 3, 2026 12:27

bartlomiejbloniarz force-pushed the export-D93596770 branch from dfffda3 to f102dbe Compare March 3, 2026 12:31

bartlomiejbloniarz force-pushed the export-D93596770 branch from f102dbe to 6675f95 Compare March 3, 2026 12:35

meta-codesync bot force-pushed the export-D93596770 branch from 6675f95 to c66970c Compare March 3, 2026 14:08

bartlomiejbloniarz force-pushed the export-D93596770 branch from c66970c to 639c289 Compare March 3, 2026 14:11

bartlomiejbloniarz force-pushed the export-D93596770 branch from 639c289 to 41f59c4 Compare March 3, 2026 14:19

meta-codesync bot closed this in 1d47693 Mar 4, 2026

Conversation

bartlomiejbloniarz commented Feb 18, 2026 • edited by coado Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

meta-codesync bot commented Feb 18, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Job Summary for Gradle

Test All :: build_android

Uh oh!

react-native-bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Job Summary for Gradle

Test All :: build_android

Uh oh!

github-actions bot commented Mar 3, 2026

Job Summary for Gradle

Test All :: run_fantom_tests

Uh oh!

github-actions bot commented Mar 3, 2026

Job Summary for Gradle

Test All :: run_fantom_tests

Uh oh!

github-actions bot commented Mar 3, 2026

Job Summary for Gradle

Test All :: build_android

Uh oh!

react-native-bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Job Summary for Gradle

Test All :: build_android

Uh oh!

react-native-bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Job Summary for Gradle

Test All :: build_android

Uh oh!

github-actions bot commented Mar 3, 2026

Job Summary for Gradle

Test All :: run_fantom_tests

Uh oh!

github-actions bot commented Mar 3, 2026

Job Summary for Gradle

Test All :: run_fantom_tests

Uh oh!

github-actions bot commented Mar 3, 2026

Job Summary for Gradle

Test All :: run_fantom_tests

Uh oh!

react-native-bot commented Mar 3, 2026

Uh oh!

react-native-bot commented Mar 3, 2026

Uh oh!

react-native-bot commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bartlomiejbloniarz commented Feb 18, 2026 •

edited by coado

Loading